mersenneforum.org  

Go Back   mersenneforum.org > Factoring Projects > YAFU

Reply
 
Thread Tools
Old 2015-10-29, 10:05   #1
Happy5214
 
Happy5214's Avatar
 
"Alexander"
Nov 2008
The Alamo City

389 Posts
Lightbulb Rho code

I was looking through some of the code in yafu's rho implementation, and I noticed a few issues. Going through the SVN version history, it doesn't appear that the code uses Montgomery arithmetic anymore, so the comments need updating. t2 is not used at all, so that's a waste of time and memory. Finally, the logged equations are not the ones being used. Instead of using 3, 2, and 1 for c, it's using 0, 1, and 2. It won't find anything when c = 0, so that needs to be fixed. Just some minor thoughts.
Happy5214 is offline   Reply With Quote
Old 2015-10-29, 17:04   #2
bsquared
 
bsquared's Avatar
 
"Ben"
Feb 2007

2·17·97 Posts
Default

Thanks, you are exactly right. The bit about the constant in particular is a good catch. I've updated SVN.
bsquared is offline   Reply With Quote
Old 2015-11-01, 20:30   #3
Stargate38
 
Stargate38's Avatar
 
"Daniel Jackson"
May 2011
14285714285714285714

10010111102 Posts
Default

Can you please update the binaries? I've been waiting for quite a long time for a new version.
Stargate38 is offline   Reply With Quote
Old 2015-11-01, 21:54   #4
bsquared
 
bsquared's Avatar
 
"Ben"
Feb 2007

2·17·97 Posts
Default

Quote:
Originally Posted by Stargate38 View Post
Can you please update the binaries? I've been waiting for quite a long time for a new version.
Making an official release is a lot of work. You might be better off learning how to compile it yourself, which you can do with 100% free tools. I and others would probably be willing to answer any questions you might have once you start.
bsquared is offline   Reply With Quote
Reply

Thread Tools


Similar Threads
Thread Thread Starter Forum Replies Last Post
Please help me with my code daxmick Programming 15 2014-02-14 11:57
Code Help Andrew Programming 12 2013-02-16 20:53
New Code JohnFullspeed Programming 20 2011-09-04 04:28
Code Primeinator Software 20 2009-06-11 22:22
A little help with VBS code IronBits No Prime Left Behind 6 2008-11-12 14:23

All times are UTC. The time now is 15:48.

Wed Oct 28 15:48:08 UTC 2020 up 48 days, 12:59, 3 users, load averages: 1.88, 1.73, 1.78

Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2020, Jelsoft Enterprises Ltd.

This forum has received and complied with 0 (zero) government requests for information.

Permission is granted to copy, distribute and/or modify this document under the terms of the GNU Free Documentation License, Version 1.2 or any later version published by the Free Software Foundation.
A copy of the license is included in the FAQ.