Rho code

Happy5214 · 2015-10-29, 10:05

I was looking through some of the code in yafu's rho implementation, and I noticed a few issues. Going through the SVN version history, it doesn't appear that the code uses Montgomery arithmetic anymore, so the comments need updating. t2 is not used at all, so that's a waste of time and memory. Finally, the logged equations are not the ones being used. Instead of using 3, 2, and 1 for c, it's using 0, 1, and 2. It won't find anything when c = 0, so that needs to be fixed. Just some minor thoughts.

bsquared · 2015-10-29, 17:04

Thanks, you are exactly right. The bit about the constant in particular is a good catch. I've updated SVN.

Stargate38 · 2015-11-01, 20:30

Can you please update the binaries? I've been waiting for quite a long time for a new version.

bsquared · 2015-11-01, 21:54

Quote:

Originally Posted by Stargate38

Can you please update the binaries? I've been waiting for quite a long time for a new version.

Making an official release is a lot of work. You might be better off learning how to compile it yourself, which you can do with 100% free tools. I and others would probably be willing to answer any questions you might have once you start.

2015-10-29, 10:05	#1
Happy5214 "Alexander" Nov 2008 The Alamo City 1631₈ Posts	Rho code I was looking through some of the code in yafu's rho implementation, and I noticed a few issues. Going through the SVN version history, it doesn't appear that the code uses Montgomery arithmetic anymore, so the comments need updating. t2 is not used at all, so that's a waste of time and memory. Finally, the logged equations are not the ones being used. Instead of using 3, 2, and 1 for c, it's using 0, 1, and 2. It won't find anything when c = 0, so that needs to be fixed. Just some minor thoughts.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Please help me with my code	daxmick	Programming	15	2014-02-14 11:57
Code Help	Andrew	Programming	12	2013-02-16 20:53
New Code	JohnFullspeed	Programming	20	2011-09-04 04:28
Code	Primeinator	Software	20	2009-06-11 22:22
A little help with VBS code	IronBits	No Prime Left Behind	6	2008-11-12 14:23

2015-10-29, 17:04	#2
bsquared "Ben" Feb 2007 7225₈ Posts	Thanks, you are exactly right. The bit about the constant in particular is a good catch. I've updated SVN.

2015-11-01, 20:30	#3
Stargate38 "Daniel Jackson" May 2011 14285714285714285714 3×251 Posts	Can you please update the binaries? I've been waiting for quite a long time for a new version.