View Single Post
Old 2020-07-17, 13:13   #567
EdH
 
EdH's Avatar
 
"Ed Hall"
Dec 2009
Adirondack Mtns

1101000100102 Posts
Default

Quote:
Originally Posted by ChristianB View Post
Could you please add your changes or proposals as an issue or pull request to https://github.com/ChristianBeer/aliqueit ? I would like to make a new version later this year and it would prevent extra effort if we shared also the small improvements.
I am looking at GitHub, but don't have an account. Since I'm totally unfamiliar with its workings (other than being able to retrieve stuff) I'm at a loss.

Side note: The current aliqueit.ini has a ";" after false in line 74 that needs to be removed.

On to aliqueit.cc. The following removes the b2scale references:
Code:
 --- aliqueit-orig.cc    2018-09-28 10:08:04.000000000 -0400
+++ aliqueit.cc    2020-07-17 08:35:01.907686619 -0400
@@ -250,8 +250,8 @@
         log_msg("\n", false);
         log_msg(msg + "\n");
         cout << msg << "              \r" << flush;
-        system(("echo " + input_number + " | " + cfg.ecm_cmd + " -pm1 -B2scale "
-                + tostring(cfg.b2scale_pm1) + " " + tostring(pb1) + " > " + cfg.ecm_tempfile).c_str());
+        system(("echo " + input_number + " | " + cfg.ecm_cmd + " -pm1 "
+                + tostring(pb1) + " > " + cfg.ecm_tempfile).c_str());
         int num_facs = find_log_factors_gmp_ecm(cfg.ecm_tempfile, input_number, "Factor found", ": ", new_factors);
         if (num_facs) {
             check_for_neat_factors(new_factors, cfg.neat_factor_limit_pm1);
@@ -264,8 +264,8 @@
         log_msg("\n", false);
         log_msg(msg + "\n");
         cout << msg << "              \r" << flush;
-        system(("echo " + input_number + " | " + cfg.ecm_cmd + " -one -pp1 -c 3 -B2scale "
-                + tostring(cfg.b2scale_pp1) + " " + tostring(pb1) + " > " + cfg.ecm_tempfile).c_str());
+        system(("echo " + input_number + " | " + cfg.ecm_cmd + " -one -pp1 -c 3 "
+                + tostring(pb1) + " > " + cfg.ecm_tempfile).c_str());
         num_facs = find_log_factors_gmp_ecm(cfg.ecm_tempfile, input_number, "Factor found", ": ", new_factors);
         if (num_facs) {
             check_for_neat_factors(new_factors, cfg.neat_factor_limit_pp1);
@@ -280,10 +280,10 @@
         cout << msg << "              \r" << flush;
         if (cfg.use_ecmpy) { //use ecm.py for multithreading
             system(("echo " + input_number + " | " + cfg.ecmpy_cmd + " -one -c " + tostring(curves)
-                    + " -B2scale " + tostring(cfg.b2scale_ecm) + " -out " + cfg.ecm_tempfile + " " + tostring(b1)).c_str());
+                    + " -out " + cfg.ecm_tempfile + " " + tostring(b1)).c_str());
         } else { //use regular ecm
             system(("echo " + input_number + " | " + cfg.ecm_cmd + " -one -c " + tostring(curves)
-                    + " -B2scale " + tostring(cfg.b2scale_ecm) + " " + tostring(b1) + " > " + cfg.ecm_tempfile).c_str());
+                    + " " + tostring(b1) + " > " + cfg.ecm_tempfile).c_str());
         }
         num_facs = find_log_factors_gmp_ecm(cfg.ecm_tempfile, input_number, "Factor found", ": ", new_factors);
         if (num_facs) {
I did not address the b2scale references in the aliqueit.ini file. I believe they can safely be deleted, but I haven't verified it.
EdH is offline   Reply With Quote