View Single Post
Old 2014-09-06, 16:50   #647
Mark Rose
 
Mark Rose's Avatar
 
"/X\(‘-‘)/X\"
Jan 2013

54448 Posts
Default

Quote:
Originally Posted by James Heinrich View Post
Two minor issues I found in your patch:
a) The "B1" parameter is not needed when submitting results (but not harmful either, so doesn't matter if it remains).
b) You changed the login page from /default.php to /account/default.php which again isn't harmful, but not necessary (unless there was a reason for it that I missed?)
I had changed the login page to account/default.php when the homepage log in was no longer working. I've updated my fork and I've submitted another pull request to teknohog with these changes. He merged my previous pull request already.
Mark Rose is offline   Reply With Quote