Thread: Rho code
View Single Post
Old 2015-10-29, 10:05   #1
Happy5214's Avatar
Nov 2008
The Alamo City

22×7×31 Posts
Lightbulb Rho code

I was looking through some of the code in yafu's rho implementation, and I noticed a few issues. Going through the SVN version history, it doesn't appear that the code uses Montgomery arithmetic anymore, so the comments need updating. t2 is not used at all, so that's a waste of time and memory. Finally, the logged equations are not the ones being used. Instead of using 3, 2, and 1 for c, it's using 0, 1, and 2. It won't find anything when c = 0, so that needs to be fixed. Just some minor thoughts.
Happy5214 is offline   Reply With Quote