View Single Post
Old 2020-08-03, 15:04   #580
EdH
 
EdH's Avatar
 
"Ed Hall"
Dec 2009
Adirondack Mtns

5·677 Posts
Default

Quote:
Originally Posted by ChristianB View Post
@Ed:

I fixed both issues. I don't add spaces like you but instead replace the tab with the correct amount of spaces (diff 4c1bfb26 on github). This also turned out to be faster (albeit not much, considering that this functions is not called very often) and invlolved more math (although I had to correct it [diff 28b4de02 on github] because my own math was weak).

The other issue with the surplus 1 in the factor list is fixed by diff eca1a97d on github. The cause was some code I added to test the factors of the previous index before trial factoring.

You can download the current code with this link: https://github.com/ChristianBeer/ali...ive/master.zip.
Thanks for all the work, Chris. I'll change my "How I ..." thread to reflect the current revision sometime soon. I see the link is still the same. That's great.
EdH is offline   Reply With Quote