mersenneforum.org

mersenneforum.org (https://www.mersenneforum.org/index.php)
-   YAFU (https://www.mersenneforum.org/forumdisplay.php?f=96)
-   -   Rho code (https://www.mersenneforum.org/showthread.php?t=20590)

Happy5214 2015-10-29 10:05

Rho code
 
I was looking through some of the code in yafu's rho implementation, and I noticed a few issues. Going through the SVN version history, it doesn't appear that the code uses Montgomery arithmetic anymore, so the comments need updating. [FONT=Courier New]t2[/FONT] is not used at all, so that's a waste of time and memory. Finally, the logged equations are [I]not[/I] the ones being used. Instead of using 3, 2, and 1 for [I]c[/I], it's using 0, 1, and 2. It won't find anything when [I]c[/I] = 0, so that needs to be fixed. Just some minor thoughts.

bsquared 2015-10-29 17:04

Thanks, you are exactly right. The bit about the constant in particular is a good catch. I've updated SVN.

Stargate38 2015-11-01 20:30

Can you please update the binaries? I've been waiting for quite a long time for a new version.

bsquared 2015-11-01 21:54

[QUOTE=Stargate38;414516]Can you please update the binaries? I've been waiting for quite a long time for a new version.[/QUOTE]

Making an official release is a lot of work. You might be better off learning how to compile it yourself, which you can do with 100% free tools. I and others would probably be willing to answer any questions you might have once you start.


All times are UTC. The time now is 06:42.

Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2021, Jelsoft Enterprises Ltd.